Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: enable debug logs in conformance-clustermesh workflows #26186

Merged
merged 1 commit into from Jun 22, 2023
Merged

gha: enable debug logs in conformance-clustermesh workflows #26186

merged 1 commit into from Jun 22, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 13, 2023 •
edited

Let's enable debug-level logs in conformance-clustermesh workflows, as they might be useful when investigating possible flakes to gather more information.

Link to successful run: https://github.com/cilium/cilium/actions/runs/5256914992/jobs/9498930808?pr=26186

@giorio94
gha: enable debug logs in conformance-clustermesh workflows
810dc8f 
Let's enable debug-level logs, as they might be useful when
investigating possible flakes to gather more information.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Jun 13, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-debug branch from cb6353d to 810dc8f Compare June 13, 2023 15:11
@giorio94 giorio94 marked this pull request as ready for review June 13, 2023 15:11
@giorio94 giorio94 requested review from a team as code owners June 13, 2023 15:11
@giorio94 giorio94 requested a review from brlbil June 13, 2023 15:11
brlbil
brlbil approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern was would this change affect test execution time.
The test run took 18m18s, well within the average run time.

@giorio94
Copy link
Member Author

My only concern was would this change affect test execution time. The test run took 18m18s, well within the average run time.

I don't think it should affect the execution time, as it only changes the verbosity of the cilium logs, which are retrieved only in case of failures.

@giorio94
Copy link
Member Author

Marking as ready to merge, as reviews are in, and this is a gha change only.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 22, 2023
@borkmann borkmann merged commit 450e090 into main Jun 22, 2023
50 checks passed
@borkmann borkmann deleted the pr/giorio94/conformance-clustermesh-debug branch June 22, 2023 12:00
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giorio94 @brlbil @borkmann