auth: feature flag for authentication #26208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/enhancement
|
/test |
youngnick
reviewed
Jun 14, 2023
| @@ -2964,6 +2964,9 @@ sctp: | |||
|
|
|||
| # Configuration for types of authentication for Cilium | |||
| authentication: | |||
| # -- Enable authentication processing and garbage collection. | |||
| # Note that this doesn't affect auth policy enforcement. | |||
There was a problem hiding this comment.
I think this could use a little more explanation - maybe something about what happens when it's disabled? That is, what stops running, and what won't work?
As written, it sounds like disabling authentication won't affect that auth policy enforcement works properly, which doesn't seem right?
There was a problem hiding this comment.
@youngnick good point. i tried to come up with a better comment. PTAL
mhofstetter
added
the
release-blocker/1.14
Up to this point, only the SPIRE installation & integration were put behind a feature flag. Authentication, re-authentication & garbage collection were always active. This commit introduces an additional feature flag to disable the auth module that is enabled by default. Cilium config: `auth-mesh-enabled` Helm value: `authentication.enabled` Be aware, that this doesn't affect the auth policy enforcement. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/auth-feature-flag
branch
from
cd95a7e
to
7075a7d
Compare
|
/test |
youngnick
approved these changes
Jun 15, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to this point, only the SPIRE installation & integration were put behind a feature flag. Authentication, re-authentication & garbage collection were always active.
This PR introduces an additional feature flag to be able to disable the auth module if necessary. It is enabled by default.
Cilium config:
auth-mesh-enabledHelm value:
authentication.enabledNote that if disabled, policy enforcement will still block requests that require authentication. But the resulting authentication requests for these requests will not be processed, therefore the requests not be allowed.