Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: lb: minor cleanups #26216

Merged
merged 3 commits into from Jun 16, 2023
Merged

bpf: lb: minor cleanups #26216

merged 3 commits into from Jun 16, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 14, 2023 •
edited

Some innocent cleanups from figuring out what this REV_NAT_F_TUPLE_SADDR thing is. And one trivial patch for lb*_local() I had pending for a while.

@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Jun 14, 2023
@julianwiedmann julianwiedmann changed the title 1.14 bpf lb cleanups bpf: lb: minor cleanups Jun 14, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
bpf: lb: clean up saddr handling in __lb*_rev_nat()
59bcb2b 
As workaround for older kernels, we currently copy the new_saddr from the
NAT entry to a temporary stack variable.

But with the bump to kernel 4.19 this is no longer needed, we can just
access the NAT entry directly.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: lb: clean up __lb4_rev_nat()
3c30e76 
Group all the code together that handles the rewrite for the L4 header.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: lb: remove redundant reset of key->backend_slot
943a15c 
For better or worse, lb*_lookup_service() already does this for us.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review June 15, 2023 05:41
@julianwiedmann julianwiedmann requested a review from a team as a code owner June 15, 2023 05:41
@julianwiedmann julianwiedmann merged commit 5cb8a33 into cilium:main Jun 16, 2023
65 checks passed
@julianwiedmann julianwiedmann deleted the 1.14-bpf-lb-cleanups branch June 16, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@dylandreimerink dylandreimerink Awaiting requested review from dylandreimerink dylandreimerink is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @borkmann