Remove custom iproute2 fork #26221
Merged
Remove custom iproute2 fork #26221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
ti-mo
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ti-mo
added
sig/loader
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
ti-mo
force-pushed
the
tb/remove-iproute2-fork
branch
from
5ec6c76
to
9685548
Compare
ti-mo
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
|
/test |
sayboras
added
the
dont-merge/needs-rebase
zacharysarah
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
@ti-mo Good work, only nits to fix. Approving with the understanding that changes are required prior to merge. Also:
My hero. 😻
borkmann
approved these changes
Jun 16, 2023
ti-mo
force-pushed
the
tb/remove-iproute2-fork
branch
from
c52bdbd
to
a373534
Compare
ti-mo
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
I'm seeing a trend! |
|
/test |
This has been unmaintained for years and depends on llvm7, which is unlikely to work with current versions of Cilium. Remove from the repository. Signed-off-by: Timo Beckers <timo@isovalent.com>
Also fix a typo in runtime/builder image anchor. Signed-off-by: Timo Beckers <timo@isovalent.com>
As of Cilium 1.14, it no longer uses the ip command to load BPF programs into the kernel. This means we no longer need to maintain our patches on top of iproute2 and we no longer depend on a custom build in order for Cilium to run. Signed-off-by: Timo Beckers <timo@isovalent.com>
See previous commit, a custom version of iproute2 is no longer required to run Cilium, and we no longer ship it in the official container images. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/remove-iproute2-fork
branch
from
6930989
to
b3ea06f
Compare
ti-mo
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
borkmann
removed
the
dont-merge/needs-rebase
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
|
/test |
ti-mo
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #26162. (PR from personal fork)
As of Cilium 1.14, it no longer uses the ip command to load BPF programs into the kernel. This means we no longer need to maintain our patches on top of iproute2 and we no longer depend on a custom build in order for Cilium to run.
Remove cilium-iproute2 references from the documentation.
Also remove the contrib/ansible directory that was partly dedicated to building and installing this custom iproute2.
Fixes: #24579.