Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: test kvstoremesh in conformance-clustermesh #26223

Merged
merged 2 commits into from Jun 22, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jun 14, 2023

Let's test kvstoremesh in addition to plain clustermesh through the conformance-clustermesh workflow, enabling the new mode for a subset of the matrix entries.

Link to successful run: https://github.com/cilium/cilium/actions/runs/5345487740

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Jun 14, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-kvstoremesh branch 3 times, most recently from 4158ee4 to 062f762 Compare June 19, 2023 16:27
Fix the encryption check while building the helm settings, to ensure
that encryption is effectively disabled when it should be. There's no
actual difference though, since encryption was disabled also before
because the type was neither ipsec nor wireguard.

Fixes: 81a6e10 ("gha: use Cilium CLI Helm mode for conformance-clustermesh")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Let's test kvstoremesh in addition to plain clustermesh through the
conformance-clustermesh workflow, enabling the new mode for a subset of
the matrix entries.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-kvstoremesh branch 2 times, most recently from 338ffba to 3910d7f Compare June 22, 2023 13:10
@giorio94 giorio94 marked this pull request as ready for review June 22, 2023 13:10
@giorio94 giorio94 requested review from a team as code owners June 22, 2023 13:10
@giorio94 giorio94 requested a review from brlbil June 22, 2023 13:10
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giorio94
Copy link
Member Author

Reviews are in. Marking as ready to merge given that this changes GHA workflows only.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 22, 2023
@borkmann borkmann merged commit 036aa0c into main Jun 22, 2023
53 checks passed
@borkmann borkmann deleted the pr/giorio94/conformance-clustermesh-kvstoremesh branch June 22, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants