gateway-api: Enable HTTPRouteListenerHostnameMatching test #26226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
Commit 1f6d0e4b53acb3d5f77a81a28f2049f5373d4130 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
sayboras
force-pushed
the
tam/gha-gateway-api
branch
from
1f6d0e4
to
c4d1765
Compare
|
Commit 1f6d0e4b53acb3d5f77a81a28f2049f5373d4130 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
sayboras
force-pushed
the
tam/gha-gateway-api
branch
from
c4d1765
to
b61231d
Compare
This was fixed as part of recent refactor and v0.7.0 upgrade. Fixes: cilium#24217 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gha-gateway-api
branch
from
b61231d
to
76d1203
Compare
|
Full CI is not required as the changes are limited to GHA flake. |
sayboras
added
area/servicemesh
|
The commit link in description is broken, as PR doesn't contain the commit anymore. A working link is here: sayboras@c4d1765 |
aspsk
approved these changes
Jun 15, 2023
jrajahalme
approved these changes
Jun 15, 2023
brlbil
approved these changes
Jun 19, 2023
|
Review from the required groups is in, full CI is not required, marking this ready to merge. |
sayboras
added
the
ready-to-merge
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was fixed as part of a recent refactor and v0.7.0 upgrade.
Fixes: #24217
Testing
Testing was done with the temp commit triggering conformance test 20 times in the same workflow run.
https://github.com/cilium/cilium/actions/runs/5267708914/jobs/9523337823?pr=26226