Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add Bandwidth Manager in CI #26243

Open
aanm opened this issue Jun 14, 2023 · 6 comments
Open

Re-add Bandwidth Manager in CI #26243

aanm opened this issue Jun 14, 2023 · 6 comments
Assignees
@Jack-R-lantern
Labels
area/CI Continuous Integration testing issue or flake feature/bandwidth-manager Impacts BPF bandwidth manager. sig/agent Cilium agent related. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@aanm
Copy link
Member

aanm commented Jun 14, 2023 •
edited

One of the limitations of GH actions is the inability of running Bandwidth Manager feature on our CI as described in the "cons" section in #25713

To provide the same coverage we should add a test for this functionality in the connectivity tests of cilium-cli as it would be nice to test this feature.

The ginkgo test can be found in https://github.com/cilium/cilium/blob/ad36a8c65cd944cd8cbf227e383304f9c14c0ab8/test/k8s/bandwidth.go
@aanm aanm added area/CI Continuous Integration testing issue or flake sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/agent Cilium agent related. labels Jun 14, 2023
@Jack-R-lantern
Copy link
Contributor

Can I be assigned this issue?

@aanm
Copy link
Member Author

aanm commented Jul 7, 2023

Yes, sounds good. Do you have a PR in mind? @Jack-R-lantern

@Jack-R-lantern
Copy link
Contributor

Not yet, But I'll try to fix that as soon as possible.
Can I add test here? @aanm

@aanm
Copy link
Member Author

aanm commented Jul 7, 2023

Ideally the test would be part of the cilium-cli as a connectivity test. Similar to https://github.com/cilium/cilium-cli/tree/main/connectivity/tests

@Jack-R-lantern
Copy link
Contributor

Jack-R-lantern commented Jul 11, 2023 •
edited

I know you're busy and I'm really sorry.
But I need confirmation, I'm trying to implement it here, did I understand your intention correctly? @aanm

@aanm
Copy link
Member Author

aanm commented Jul 12, 2023

@Jack-R-lantern yep, that would be the right place.

@Jack-R-lantern Jack-R-lantern mentioned this issue Jul 13, 2023
Draft
@julianwiedmann julianwiedmann added the feature/bandwidth-manager Impacts BPF bandwidth manager. label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-R-lantern Jack-R-lantern

Labels
area/CI Continuous Integration testing issue or flake feature/bandwidth-manager Impacts BPF bandwidth manager. sig/agent Cilium agent related. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aanm @julianwiedmann @Jack-R-lantern