Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Upgrade Note For Deny Policy Fix #26245

Merged
merged 1 commit into from Jun 29, 2023
Merged

docs: Upgrade Note For Deny Policy Fix #26245

merged 1 commit into from Jun 29, 2023

Conversation

nathanjsweet
Copy link
Member

No description provided.

@nathanjsweet nathanjsweet added release-note/misc This PR makes changes that have no direct user impact. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. labels Jun 15, 2023
@nathanjsweet nathanjsweet requested a review from a team as a code owner June 15, 2023 01:09
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/update-upgrade-docs-for-deny-policy-fix branch from aa91cf3 to 1956f78 Compare June 15, 2023 03:34
zacharysarah
zacharysarah requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanjsweet Good start! Some edits for clarity, and see my concurrence with @joestringer about what else this PR requires.

Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
@joestringer joestringer added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jun 20, 2023
@joestringer joestringer marked this pull request as draft June 26, 2023 22:24
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/update-upgrade-docs-for-deny-policy-fix branch 2 times, most recently from 9e2de82 to 6fdbeb6 Compare June 27, 2023 21:12
@nathanjsweet nathanjsweet marked this pull request as ready for review June 27, 2023 21:27
zacharysarah
zacharysarah requested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits

Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
@nathanjsweet
docs: Upgrade Note For Deny Policy Fix
53ca457 
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/update-upgrade-docs-for-deny-policy-fix branch from 6fdbeb6 to 53ca457 Compare June 28, 2023 15:09
zacharysarah
zacharysarah approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nathanjsweet nathanjsweet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 28, 2023
@borkmann borkmann merged commit 7af6450 into main Jun 29, 2023
40 checks passed
@borkmann borkmann deleted the pr/nathanjsweet/update-upgrade-docs-for-deny-policy-fix branch June 29, 2023 07:46
@borkmann borkmann added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jun 29, 2023
@joamaki joamaki mentioned this pull request Jul 5, 2023
Merged
23 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 5, 2023
@jibi jibi added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 10, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nathanjsweet @joestringer @zacharysarah @jibi @borkmann @joamaki