Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace client-go with private fork. #26250

Merged
merged 1 commit into from Jun 15, 2023
Merged

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jun 15, 2023

Our private fork contains fix to exponential backoff in client-go for informers, that
wasn't backported in k8s: kubernetes/kubernetes#118132

@marseel marseel requested a review from a team as a code owner June 15, 2023 09:57
@marseel marseel requested a review from tklauser June 15, 2023 09:57
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 15, 2023
@marseel marseel added the release-note/misc This PR makes changes that have no direct user impact. label Jun 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 15, 2023
@marseel marseel force-pushed the update_client_go branch 2 times, most recently from d8fbefc to 8629bff Compare June 15, 2023 10:07
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits. Otherwise, the new backoff seems very neat! Thanks

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Our private fork contains fix to exponential backoff in client-go for
informers, that
wasn't backported: kubernetes/kubernetes#118132

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@tklauser
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 15, 2023
@tklauser tklauser merged commit 00d8462 into cilium:main Jun 15, 2023
58 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants