New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: rebuild ginkgo tests in case of cache miss #26263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @aanm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Thanks!
I wonder if it could make sense to add a comment to the original steps, to point out that there is another copy down here, and they should be kept in sync in case a modification is performed.
When a test is re-trigger after a long period of time, the test binary might already been deleted from the GitHub cache. If we hit a cache miss we should rebuild the binary so that the test can continue to be executed. Signed-off-by: André Martins <andre@cilium.io>
Same as cilium#26263, but for conformance-runtime test. Signed-off-by: Tam Mach <tam.mach@cilium.io>
Same as #26263, but for conformance-runtime test. Signed-off-by: Tam Mach <tam.mach@cilium.io>
[upstream commit a49552e] Same as cilium#26263, but for conformance-runtime test. Signed-off-by: Tam Mach <tam.mach@cilium.io>
[upstream commit a49552e] Same as cilium#26263, but for conformance-runtime test. Signed-off-by: Tam Mach <tam.mach@cilium.io> Signed-off-by: Andrew Sauber <2046750+asauber@users.noreply.github.com>
When a test is re-trigger after a long period of time, the test binary might already been deleted from the GitHub cache. If we hit a cache miss we should rebuild the binary so that the test can continue to be executed.