Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: rebuild ginkgo tests in case of cache miss #26263

Merged
merged 1 commit into from Jun 16, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 15, 2023

When a test is re-trigger after a long period of time, the test binary might already been deleted from the GitHub cache. If we hit a cache miss we should rebuild the binary so that the test can continue to be executed.

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Jun 15, 2023
@aanm aanm requested review from a team as code owners June 15, 2023 12:50
@aanm aanm requested review from nbusseneau and brlbil and removed request for nbusseneau June 15, 2023 12:50
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @aanm

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks!

I wonder if it could make sense to add a comment to the original steps, to point out that there is another copy down here, and they should be kept in sync in case a modification is performed.

When a test is re-trigger after a long period of time, the test binary
might already been deleted from the GitHub cache. If we hit a cache miss
we should rebuild the binary so that the test can continue to be
executed.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm merged commit 143738e into cilium:main Jun 16, 2023
36 of 37 checks passed
@aanm aanm deleted the pr/fix-cache-miss branch June 16, 2023 13:08
sayboras added a commit to sayboras/cilium that referenced this pull request Jul 31, 2023
Same as cilium#26263, but for conformance-runtime test.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Jul 31, 2023
Same as #26263, but for conformance-runtime test.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/cilium that referenced this pull request Aug 1, 2023
[upstream commit a49552e]

Same as cilium#26263, but for conformance-runtime test.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Aug 1, 2023
[upstream commit a49552e]

Same as #26263, but for conformance-runtime test.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
dylandreimerink pushed a commit that referenced this pull request Aug 2, 2023
[upstream commit a49552e]

Same as #26263, but for conformance-runtime test.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
ldelossa pushed a commit to ldelossa/cilium that referenced this pull request Sep 27, 2023
[upstream commit a49552e]

Same as cilium#26263, but for conformance-runtime test.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Andrew Sauber <2046750+asauber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants