helm: address review comments regarding helm value docs #26296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/documentation
tklauser
force-pushed
the
pr/tklauser/helm-envoyconfig-doc
branch
from
245d6da
to
00ef7e8
Compare
Ref. #26005 (review) Co-authored-by: Sarah Corleissen <sarah.corleissen@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/helm-envoyconfig-doc
branch
from
00ef7e8
to
25899c5
Compare
zacharysarah
approved these changes
Jun 16, 2023
|
/test |
sayboras
approved these changes
Jun 16, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #26005 (review)
PR #26005 was merged without these review comments being addressed.