Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: Improve IPv6 BIG TCP probing #26303

Merged
merged 2 commits into from Jun 16, 2023
Merged

cilium: Improve IPv6 BIG TCP probing #26303

merged 2 commits into from Jun 16, 2023

Conversation

borkmann
Copy link
Member

See commits, this enhances availability probing of IPv6 BIG TCP.

@borkmann
vendor: Update vishvananda/netlink/
25546ab 
Update vishvananda/netlink in order to support getting IFLA_TSO_MAX_SIZE
and IFLA_TSO_MAX_SEGS.

Used the following series of commands:

  go mod edit -replace github.com/vishvananda/netlink=github.com/cilium/netlink@main
  go mod tidy
  go mod vendor
  git add vendor/ go.mod go.sum && git commit -sa

Currently pointing to our local repo as an unrelated commit in vishvananda/netlink
triggers a regression on Cilium side and given the below linked PR is not yet merged
upstream. Eventually, we can move back vishvananda/netlink.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: vishvananda/netlink#880
@borkmann
cilium: Improve feature probing for IPv6 BIG TCP
b57b750 
With IPv6 BIG TCP the IFLA_TSO_MAX_SIZE and IFLA_TSO_MAX_SEGS attributes
got added. So we better check on non-zero TSOMaxSize since only this one
got added in 5.19.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/netdev/20220513183408.686447-2-eric.dumazet@gmail.com/
@borkmann borkmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Jun 16, 2023
@borkmann borkmann requested review from a team as code owners June 16, 2023 11:18
@borkmann
Copy link
Member Author

/test

sayboras
sayboras approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for vendor changes 💯

qmonnet
qmonnet approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 16, 2023
@borkmann borkmann merged commit d7e1ceb into main Jun 16, 2023
61 of 63 checks passed
@borkmann borkmann deleted the pr/probe-tso branch June 16, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@sayboras sayboras sayboras approved these changes

@qmonnet qmonnet qmonnet approved these changes

@ldelossa ldelossa Awaiting requested review from ldelossa ldelossa is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@borkmann @tklauser @sayboras @qmonnet