Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: set N-bit in graceful restart #26325

Merged
merged 1 commit into from Jun 20, 2023
Merged

bgpv1: set N-bit in graceful restart #26325

merged 1 commit into from Jun 20, 2023

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Jun 16, 2023 •
edited

Set N-bit in graceful restart negotiation, so the peer can start graceful restart helper mode if HoldTime expires or there is a session reset because of configuration change. Further details in RFC-8538.

Open Message from Cilium :

image 
BGPv1: Set N-bit in graceful restart capability negotiation.

@harsimran-pabla
bgpv1: set N-bit in graceful restart
561ee51 
Set N-bit in graceful restart negotiation, so peer can trigger graceful
restart helper mode if HoldTime expires. Further details in RFC-8538.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner June 16, 2023 19:53
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 16, 2023
@harsimran-pabla harsimran-pabla added area/bgp release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jun 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 16, 2023
rastislavs
rastislavs approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimran-pabla
Copy link
Contributor Author

/test

@danehans
Copy link
Contributor

RFC-8538 provides a nice summary of graceful restart negotiation:

When a BGP session is reset, both speakers operate as "Receiving Speakers"
according to [RFC4724], meaning they retain each other's routes.
This is also true for HOLDTIME expiration. The functionality can be
defeated by sending a BGP Cease NOTIFICATION message with the Hard
Reset subcode. If a Hard Reset is used, a full session reset is
performed.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 19, 2023
@borkmann borkmann merged commit 39d9570 into cilium:main Jun 20, 2023
63 checks passed
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harsimran-pabla @danehans @rastislavs @borkmann