datapath: bigtcp: Fix the IPv4 BIG TCP may not work #26336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
PlatformLC
reviewed
Jun 20, 2023
PlatformLC
reviewed
Jun 20, 2023
ti-mo
added
kind/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
borkmann
reviewed
Jun 20, 2023
The kernel will also update the IPv4 GRO/GSO setting if the new value of
"gso/gro_max_size" isn't greater than 65536:
1. Enable IPv4 and IPv6 BIG TCP firstly:
a). Dump the agent's log:
$ kubectl -n kube-system logs cilium-tfhz5 2>&1 | grep "big-tcp"
level=info msg=" --enable-ipv4-big-tcp='true'" subsys=daemon
level=info msg=" --enable-ipv6-big-tcp='true'" subsys=daemon
level=info msg="Setting up BIG TCP" subsys=big-tcp
level=info msg="Setting IPv4 gso_max_size to 131072 and gro_max_size to 131072" device=enp0 subsys=big-tcp
level=info msg="Setting IPv6 gso_max_size to 131072 and gro_max_size to 131072" device=enp0 subsys=big-tcp
b). Check the GSO value on the host's net device:
$ ip -d -j link show dev enp0 | jq -c '.[0].gso_max_size'
131072
$ ip -d -j link show dev enp0 | jq -c '.[0].gso_ipv4_max_size'
131072
2. Then re-install the cilium by enabling IPv4 BIG TCP only:
a). Dump the agent's log:
$ kubectl -n kube-system logs cilium-zwpg6 2>&1 | grep "big-tcp"
level=info msg=" --enable-ipv4-big-tcp='true'" subsys=daemon
level=info msg=" --enable-ipv6-big-tcp='false'" subsys=daemon
level=info msg="Setting up BIG TCP" subsys=big-tcp
level=info msg="Setting IPv4 gso_max_size to 131072 and gro_max_size to 131072" device=enp0 subsys=big-tcp
level=info msg="Setting IPv6 gso_max_size to 65536 and gro_max_size to 65536" device=enp0 subsys=big-tcp
b). Check the GSO value on the host's net device:
$ ip -d -j link show dev enp0 | jq -c '.[0].gso_max_size'
65536
$ip -d -j link show dev enp0 | jq -c '.[0].gso_ipv4_max_size'
65536
No errors about the BIG TCP setting in cilium agent's log, but the value
of net device's '{gso,gro}_ipv4_max_size' is wrong.
So it needs to handle the IPv6 BIG TCP setting firstly, then IPv4.
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Link: https://lore.kernel.org/netdev/7e1f733cc96c7f7658fbf3276a90281b2f37acd1.1674921359.git.lucien.xin@gmail.com/
borkmann
approved these changes
Jun 20, 2023
|
/test |
ldelossa
approved these changes
Jun 20, 2023
borkmann
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel will also update the IPv4 GRO/GSO setting if the new value of
"gso/gro_max_size" isn't greater than 65536:
128000
65536
Cilium will call IPv4 GRO/GSO setup firstly, then call IPv6. To handle the
above issue, setup the IPv6 GRO/GSO firstly, then IPv4 GRO/GSO.