Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DSR section in kubeproxy-free.rst may need to be updated #26339

Closed
spacewander opened this issue Jun 18, 2023 · 2 comments · Fixed by #26582
Closed

The DSR section in kubeproxy-free.rst may need to be updated #26339

spacewander opened this issue Jun 18, 2023 · 2 comments · Fixed by #26582
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-report This was reported by a user in the Cilium community, eg via Slack. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@spacewander
Copy link
Contributor

Under the https://github.com/cilium/cilium/blob/main/Documentation/network/kubernetes/kubeproxy-free.rst#direct-server-return-dsr section, the doc claims that "DSR currently requires Cilium to be deployed in :ref:arch_direct_routing, i.e. it will not work in either tunneling mode."

However, the section after it claims that the DSR mode can work with tunnel protocol geneve.

Look like we need to update the former one?
@borkmann
Copy link
Member

Cc @julianwiedmann This indeed needs an update. Thanks for spotting!

@ti-mo ti-mo added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/community-report This was reported by a user in the Cilium community, eg via Slack. labels Jun 21, 2023
@julianwiedmann julianwiedmann mentioned this issue Jun 30, 2023
Merged
@julianwiedmann
Copy link
Member

Thank you @spacewander ! Please give #26582 a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-report This was reported by a user in the Cilium community, eg via Slack. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update KPR section on DSR julianwiedmann/cilium
4 participants
@borkmann @ti-mo @spacewander @julianwiedmann