policy: Optimize getNets() #26345
Merged
policy: Optimize getNets() #26345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getNets is used in DenyPreferredInsert for MapState. It is somewhat costly, and uses a cache to compute the result at most once for each MapStateEntry. Speed up the computation with two strategies: - skip looking for CIDR labels when the identity is not a local identity. This works due to CIDR identities always being locally allocated - skip allocating a slice when not needed, returning a nil map instead if the locally allocated identity has no CIDR labels Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
kind/enhancement
|
/test |
aditighag
reviewed
Jun 21, 2023
There was a problem hiding this comment.
I don't have much context for Deny policies. /cc @nathanjsweet
nathanjsweet
approved these changes
Jun 21, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
julianwiedmann
added
backport-done/1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getNets is used in DenyPreferredInsert for MapState. It is somewhat costly, and uses a cache to compute the result at most once for each MapStateEntry. Speed up the computation with two strategies: