Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about kvstoremesh #26348

Merged
merged 2 commits into from Jun 23, 2023
Merged

Conversation

giorio94
Copy link
Member

This PR extends the clustermesh documentation with information about the new Cilium CLI helm mode, and kvstoremesh. The PR is ready for review, but marked as blocked because the Cilium CLI has not yet been extended with the new --enable-kvstoremesh flag.

@giorio94 giorio94 added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. dont-merge/blocked Another PR must be merged before this one. labels Jun 19, 2023
@giorio94 giorio94 requested review from a team as code owners June 19, 2023 10:35
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@giorio94
Copy link
Member Author

Last force push just added an additional note that kvstoremesh is a beta feature close to the instructions to enable it:

-  You can additionally opt in to :ref:`kvstoremesh` when enabling Cluster Mesh.
-  Make sure to configure the Cilium CLI in *helm* mode and run:
+  You can additionally opt in to :ref:`kvstoremesh` (beta feature) when enabling
+  Cluster Mesh. Make sure to configure the Cilium CLI in *helm* mode and run:

Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it. lgtm

This commit extends the "Setting up Cluster Mesh" documentation page to
mention the new Cilium CLI *helm* mode, which supports more advanced
functionalities and configuration options.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This commit extends the documentation with a brief description about the
new KVStoreMesh functionality, and instructions about how to enable it.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94
Copy link
Member Author

I've bumped the CLI version mentioned in the clustermesh docs to v0.14.8, as it will be the one supporting all clustermesh operations using helm, as well as including the --enable-kvstoremesh flag. I'm going to remove the blocked label from this PR once that gets released.

@giorio94
Copy link
Member Author

Cilium CLI v0.14.8 got released. Marking as ready to merge

@giorio94 giorio94 added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/blocked Another PR must be merged before this one. labels Jun 23, 2023
@borkmann borkmann merged commit f226df6 into cilium:main Jun 23, 2023
40 checks passed
@giorio94 giorio94 deleted the mio/kvstoremesh-doc branch July 7, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants