New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about kvstoremesh #26348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
3415860
to
37acda7
Compare
Last force push just added an additional note that kvstoremesh is a beta feature close to the instructions to enable it: - You can additionally opt in to :ref:`kvstoremesh` when enabling Cluster Mesh.
- Make sure to configure the Cilium CLI in *helm* mode and run:
+ You can additionally opt in to :ref:`kvstoremesh` (beta feature) when enabling
+ Cluster Mesh. Make sure to configure the Cilium CLI in *helm* mode and run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding it. lgtm
This commit extends the "Setting up Cluster Mesh" documentation page to mention the new Cilium CLI *helm* mode, which supports more advanced functionalities and configuration options. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This commit extends the documentation with a brief description about the new KVStoreMesh functionality, and instructions about how to enable it. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
37acda7
to
cb5528c
Compare
I've bumped the CLI version mentioned in the clustermesh docs to v0.14.8, as it will be the one supporting all clustermesh operations using helm, as well as including the |
Cilium CLI v0.14.8 got released. Marking as ready to merge |
This PR extends the clustermesh documentation with information about the new Cilium CLI helm mode, and kvstoremesh. The PR is ready for review, but marked as blocked because the Cilium CLI has not yet been extended with the new
--enable-kvstoremesh
flag.