CI Workflow: Add all Azure supported k8s versions #26356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brlbil
force-pushed
the
pr/brlbil/ci-aks-k8s-version
branch
from
406e292
to
14e2b13
Compare
brlbil
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
brlbil
force-pushed
the
pr/brlbil/ci-aks-k8s-version
branch
2 times, most recently
from
935d908
to
002a9d8
Compare
nbusseneau
requested changes
Jun 20, 2023
Comment on lines
160
to
189
|
|
||
| conformance-schema-validation: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-python@bd6b4b6205c4dbad673328db7b31b7fab9e241c0 # v4.6.1 | ||
| with: | ||
| python-version: '3.10' | ||
| - run: pip install yamale | ||
| - name: Checkout code | ||
| uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2 | ||
| with: | ||
| persist-credentials: false | ||
| # hard-code the path instead of using ${{ github.repository }} to make sure it works for forked repo as well | ||
| path: src/github.com/cilium/cilium | ||
|
|
||
| - name: Validate schema of aws, azure and gke action files | ||
| shell: bash | ||
| run: | | ||
| for dir in aws azure gke;do | ||
| for name in k8s-versions test-config; do | ||
| file_base="src/github.com/cilium/cilium/.github/actions/${dir}/${name}" | ||
| if [ -f ${file_base}.yaml ];then | ||
| yamale -s ${file_base}-schema.yaml ${file_base}.yaml; | ||
| fi | ||
| done | ||
| done | ||
|
|
There was a problem hiding this comment.
It was good that this part was highlighted because tests did not cover some of the files.
Fixed it, and separated it as a commit.
This was referenced Jun 20, 2023
nickolaev
reviewed
Jun 20, 2023
The current aks conformance tests run against one version of k8s either a specific version or the default version that is provided by the cloud provider. This commit adds all the supported k8s versions by Azure in a matrix strategy. Signed-off-by: Birol Bilgin <birol@cilium.io>
This commit adds schema validation for conformance tests action files Signed-off-by: Birol Bilgin <birol@cilium.io>
brlbil
force-pushed
the
pr/brlbil/ci-aks-k8s-version
branch
from
002a9d8
to
236187d
Compare
bimmlerd
approved these changes
Jun 21, 2023
| @@ -0,0 +1,6 @@ | |||
| include: list(include('includeItem')) | |||
There was a problem hiding this comment.
somewhat meta, but should .github/actions/ (maybe even all of .github) be CODEOWNED by by the cilium/ci-structure team instead of contributing? This feels far in the GHA action territory.
tgraf
requested changes
Jun 21, 2023
nbusseneau
approved these changes
Jun 21, 2023
nbusseneau
added
the
ready-to-merge
tgraf
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current aks conformance tests run against one version of k8s either a specific version or the default version that is provided by the cloud provider.
This PR adds all the supported k8s versions by Azure in a matrix strategy.
Other cloud providers will be added by subsequent PRs.
Normal run examples:
✅ conformance-aks-v1.12.yaml
✅ conformance-aks-v1.13.yaml
✅ conformance-aks.yaml
Schedule run simulated:
✅ conformance-aks-v1.12.yaml
❌ conformance-aks-v1.13.yaml , failures are not related cluster installation
✅ conformance-aks.yaml