New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Workflow: Add all AWS supported k8s versions #26361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jun 19, 2023
brlbil
force-pushed
the
pr/brlbil/ci-aws-k8s-versions
branch
2 times, most recently
from
June 19, 2023 21:04
ecbe175
to
959380b
Compare
brlbil
added
area/CI
Continuous Integration testing issue or flake
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
release-note/ci
This PR makes changes to the CI.
labels
Jun 19, 2023
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Jun 19, 2023
brlbil
force-pushed
the
pr/brlbil/ci-aws-k8s-versions
branch
6 times, most recently
from
June 20, 2023 13:29
11aaa7f
to
37663a8
Compare
nbusseneau
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided we address the dependency on #26356, some whitespace nits below (non-blocking).
The current awd conformance tests run against one version of k8s either a specific version or the default version that is provided by the cloud provider. This commit adds all the supported k8s versions by AWS in a matrix strategy. Signed-off-by: Birol Bilgin <birol@cilium.io>
brlbil
force-pushed
the
pr/brlbil/ci-aws-k8s-versions
branch
from
June 21, 2023 06:57
37663a8
to
d4ff75c
Compare
nbusseneau
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jun 21, 2023
bimmlerd
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contributing lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current awd conformance tests run against one version of k8s either a specific version or the default version that is provided by the cloud provider.
This commit adds all the supported k8s versions by AWS in a matrix strategy.
Normal test runs:
❌ conformance-aws-cni-v1.11.yaml, failure is not related, it has been failing for some time
✅ conformance-aws-cni-v1.12.yaml
✅ conformance-aws-cni-v1.13.yaml
✅ conformance-aws-cni.yaml
✅ conformance-eks-v1.11.yaml
✅ conformance-eks-v1.12.yaml
✅ conformance-eks-v1.13.yaml
✅ conformance-eks.yaml
Simulated scheduled runs:
❌ conformance-aws-cni-v1.11.yaml, failure is not related, it has been failing for some time
✅ conformance-aws-cni-v1.12.yaml
✅ conformance-aws-cni-v1.13.yaml
✅ conformance-aws-cni.yaml
✅ conformance-eks-v1.11.yaml
✅ conformance-eks-v1.12.yaml
✅ conformance-eks-v1.13.yaml
✅ conformance-eks.yaml
Depends on: #26356