Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-aks, ci-external-workloads: Use cilium-cli Helm mode #26382

Merged
merged 2 commits into from Jun 21, 2023
Merged

ci-aks, ci-external-workloads: Use cilium-cli Helm mode #26382

merged 2 commits into from Jun 21, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jun 20, 2023 •
edited

migrating ci-aks and ci-external-workloads to use Helm mode for #25156

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 20, 2023
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 20, 2023
@michi-covalent
Copy link
Contributor Author

michi-covalent commented Jun 20, 2023 •
edited

✅ ci-aks: https://github.com/cilium/cilium/actions/runs/5335633345/jobs/9669921350?pr=26382
✅ ci-external-workloads: https://github.com/cilium/cilium/actions/runs/5324644411/jobs/9644243418?pr=26382

removing the temporary commit

@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent marked this pull request as ready for review June 20, 2023 20:18
@michi-covalent michi-covalent requested review from a team as code owners June 20, 2023 20:18
sayboras
sayboras approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment on enabling hubble relay as part of cilium installation, but not a blocker.

LGTM ✔️

.github/workflows/conformance-aks.yaml Show resolved Hide resolved
.github/workflows/conformance-aks.yaml Show resolved Hide resolved
@michi-covalent michi-covalent added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 21, 2023
@michi-covalent
ci-aks: Use cilium-cli Helm mode
10a76e5 
Ref: #25156

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
conformance-externalworkloads: Use Helm mode cilium-cli
57e6c71 
Ref: https://github.com/cilium/cilium-cli#experimental-helm-installation-mode
Ref: #25156

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

rebased. i'll re-test aks. moving to draft.

@michi-covalent michi-covalent marked this pull request as draft June 21, 2023 14:54
@michi-covalent michi-covalent removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 21, 2023
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent marked this pull request as ready for review June 21, 2023 16:58
@michi-covalent
Copy link
Contributor Author

/test

joestringer
joestringer approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a little discussion going on below, but as long as we've validated that the new version does the same testing as the old one on the correct version, LGTM 👍

christarazi
christarazi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@christarazi christarazi added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow labels Jun 21, 2023
@michi-covalent michi-covalent merged commit b7cd3e0 into main Jun 21, 2023
63 checks passed
@michi-covalent michi-covalent deleted the pr/michi/letsgo branch June 21, 2023 20:06
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
@tklauser tklauser mentioned this pull request Jul 10, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

@sayboras sayboras sayboras approved these changes

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michi-covalent @joestringer @christarazi @sayboras