Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustermesh: fix broken test due to merge race #26389

Merged
merged 1 commit into from Jun 21, 2023

Conversation

giorio94
Copy link
Member

Due to a merge race, one of the clustermesh tests is currently broken. Let's fix it, removing a leftover reference to checkmate.

Fixes: 081c4d2 ("kvstore: prevent multiple test clients from being created in parallel")
Fixes: 5409bc5 ("clustermesh: improve reliability of TestClusterMesh")

Due to a merge race, one of the clustermesh tests is currently broken.
Let's fix it, removing a leftover reference to checkmate.

Fixes: 081c4d2 ("kvstore: prevent multiple test clients from being created in parallel")
Fixes: 5409bc5 ("clustermesh: improve reliability of TestClusterMesh")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added kind/bug/CI This is a bug in the testing code. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Jun 21, 2023
@giorio94 giorio94 requested a review from a team as a code owner June 21, 2023 07:13
@giorio94
Copy link
Member Author

Integration tests completed successfully. Marking as ready to merge.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 21, 2023
@ti-mo ti-mo merged commit 5a1770c into cilium:main Jun 21, 2023
53 checks passed
@giorio94 giorio94 deleted the mio/fix-clustermesh-test branch June 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants