Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CILIUM_CLI_MODE env variable at the top level #26404

Merged
merged 1 commit into from Jun 21, 2023
Merged

Set CILIUM_CLI_MODE env variable at the top level #26404

merged 1 commit into from Jun 21, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jun 21, 2023 •
edited

Put CILIUM_CLI_MODE environment variable at the top level to use the
Helm mode for all cilium-cli commands consistently. This pull request
updates workflows that use the issue_comment trigger.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 21, 2023
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Jun 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 21, 2023
@michi-covalent michi-covalent force-pushed the pr/michi/more-helm branch 2 times, most recently from a3fd8ac to a9c6468 Compare June 21, 2023 16:46
@michi-covalent
Copy link
Contributor Author

michi-covalent commented Jun 21, 2023 •
edited

@michi-covalent michi-covalent changed the title Consistently use cilium-cli Helm mode Set CILIUM_CLI_MODE env variable at the top level Jun 21, 2023
@michi-covalent
Consistently use cilium-cli Helm mode
dfa6512 
Put CILIUM_CLI_MODE environment variable at the top level to use the
Helm mode for all cilium-cli commands consistently.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent marked this pull request as ready for review June 21, 2023 17:37
@michi-covalent michi-covalent requested review from a team as code owners June 21, 2023 17:37
@christarazi christarazi added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow labels Jun 21, 2023
christarazi
christarazi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@michi-covalent
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 21, 2023
@michi-covalent michi-covalent merged commit 054ae88 into main Jun 21, 2023
63 checks passed
@michi-covalent michi-covalent deleted the pr/michi/more-helm branch June 21, 2023 20:59
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@brlbil brlbil brlbil approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michi-covalent @joestringer @brlbil @christarazi