Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflows: Fix matrix generation #26406

Merged
merged 1 commit into from Jun 21, 2023
Merged

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Jun 21, 2023

With recent changes, matrix strategies were added to conformance tests.
Matrix is generated from action yaml files, which are currently pulled from PR and do not exist and this fails the workflows.

This PR fixes the issue by pulling from the main.

Fixes: #26403

Test Run, matrix generation works:
https://github.com/cilium/cilium/actions/runs/5336940066/jobs/9672360262?pr=26406

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 21, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-fix-matrix-gen branch 2 times, most recently from d335a5b to 0d89b86 Compare June 21, 2023 17:32
@brlbil brlbil marked this pull request as ready for review June 21, 2023 17:33
@brlbil brlbil requested review from a team as code owners June 21, 2023 17:33
@brlbil brlbil requested a review from nbusseneau June 21, 2023 17:33
@brlbil brlbil added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Jun 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 21, 2023
@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 21, 2023
With recent changes matrix strategies added to conformance tests.
Matrix is generated from action yaml files, which are currently pulled
from PR which not exists. This fails the workflows.

This commit fixes the issue by pulling from the main.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-fix-matrix-gen branch from 0d89b86 to 088735e Compare June 21, 2023 18:28
@borkmann borkmann merged commit 34aaeae into main Jun 21, 2023
52 of 53 checks passed
@borkmann borkmann deleted the pr/brlbil/ci-fix-matrix-gen branch June 21, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: generate-matrix fails on multiple Conformance tests
3 participants