Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back Market in the USERS list #26413

Merged
merged 1 commit into from Jun 22, 2023

Conversation

NitriKx
Copy link
Contributor

@NitriKx NitriKx commented Jun 22, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Add Back Market in the list of users

@NitriKx NitriKx requested a review from a team as a code owner June 22, 2023 10:09
@maintainer-s-little-helper
Copy link

Commit 9a1f415b345a530f2ee8a31ea043b2565396cf5a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 22, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 22, 2023
@maintainer-s-little-helper
Copy link

Commit 9a1f415b345a530f2ee8a31ea043b2565396cf5a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 22, 2023
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Jun 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 22, 2023
@xmulligan
Copy link
Member

Thanks for the addition @NitriKx ! Would you be interested in doing a case study about why you chose Cilium? We would just need 30 minutes for an interview. You can see some examples here https://www.cncf.io/case-studies?_sft_lf-project=cilium

@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 22, 2023
@borkmann borkmann merged commit ab5fc66 into cilium:main Jun 22, 2023
49 of 50 checks passed
@NitriKx NitriKx deleted the add-backmarket-in-users branch June 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants