Remove validation timeout in controlplane testing #26414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
area/CI
christarazi
reviewed
Jun 22, 2023
There was a problem hiding this comment.
The change makes sense to me. I was reading the discussion in the linked issue and came across this, which made me hesitate on approving this PR. Raising it here for us to discuss whether that comment impacts this PR.
Yep, I'm working to verify what has been suggested. But I think we should consider removing the timeout anyway, to avoid possible further flakyness. |
christarazi
added
release-note/ci
christarazi
approved these changes
Jun 24, 2023
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
force-pushed
the
pr/pippolo84/improve-cpt-retry
branch
from
4f39bca
to
48568a4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pippolo84
force-pushed
the
pr/pippolo84/improve-cpt-retry
branch
from
48568a4
to
5bf0145
Compare
Due to the unpredictability of a CI environment, setting a validation timeout when running tests may lead to flakyness. At the same time, a short timeout is useful when developing locally to get faster feedback from the tests. The commit changes the controlplane test framework to run without a timeout by default. An additional method WithValidationTimeout is added to set a custom one when developing locally. Moreover, the result of each failed validation is always printed, to ease debuggability both locally and in a CI environment. Related: cilium#26082 Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/improve-cpt-retry
branch
from
5bf0145
to
c67446c
Compare
|
/test |
pippolo84
added
the
ready-to-merge
|
The only affected tests ran successfully in Travis, so marking it ready-to-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the unpredictability of a CI environment, setting a validation timeout when running tests may lead to flakyness. At the same time, a short timeout is useful when developing locally to get faster feedback from the tests.
The commit changes the controlplane test framework to run without a timeout by default. An additional method
WithValidationTimeoutis added to set a custom one when developing locally. Moreover, the result of each failed validation is always printed, to ease debuggability both locally and in a CI environment.Related: #26082