Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix the cilium-cli default branch name #26461

Merged
merged 1 commit into from Jun 23, 2023

Conversation

michi-covalent
Copy link
Contributor

The default branch name for cilium/cilium-cli repo changed from master to main. The current instructions still work because the master branch gets synched with the main branch, but let's update the docs to use the new default branch name to avoid any confusion in the future.

Ref: #26430
Ref: https://github.com/cilium/cilium-cli/blob/main/.github/workflows/mirror.yaml

The default branch name for cilium/cilium-cli repo changed from master
to main. The current instructions still work because the master branch
gets synched with the main branch, but let's update the docs to use the
new default branch name to avoid any confusion in the future.

Ref: #26430
Ref: https://github.com/cilium/cilium-cli/blob/main/.github/workflows/mirror.yaml

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested a review from a team as a code owner June 23, 2023 17:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 23, 2023
learnitall added a commit to learnitall/cilium that referenced this pull request Jun 23, 2023
This is a follow-up PR to cilium#26461 to change the branch name used
for cilium/proxy from master to main.

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Jun 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 23, 2023
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent
Copy link
Contributor Author

this pull request only modifies a file under Documentation/ directory. merging 🚀

@michi-covalent michi-covalent merged commit e7126f7 into main Jun 23, 2023
51 checks passed
@michi-covalent michi-covalent deleted the pr/michi/stable-cilium-cli branch June 23, 2023 22:01
borkmann pushed a commit that referenced this pull request Jun 26, 2023
This is a follow-up PR to #26461 to change the branch name used
for cilium/proxy from master to main.

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants