Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix the cilium/proxy default branch name #26464

Merged
merged 1 commit into from Jun 26, 2023
Merged

docs: Fix the cilium/proxy default branch name #26464

merged 1 commit into from Jun 26, 2023

Conversation

learnitall
Copy link
Contributor

This is a follow-up PR to #26461 to change the branch name used for cilium/proxy from master to main.

@learnitall
docs: Fix the cilium/proxy default branch name
0e274a2 
This is a follow-up PR to cilium#26461 to change the branch name used
for cilium/proxy from master to main.

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@learnitall learnitall requested review from a team as code owners June 23, 2023 20:02
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 23, 2023
sayboras
sayboras approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 23, 2023
@sayboras
Copy link
Member

Related to cilium/proxy#176.

Marking this ready to merge, as this is the correction for branch name reference only.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 23, 2023
meyskens
meyskens approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@borkmann borkmann merged commit f4ae255 into cilium:main Jun 26, 2023
41 checks passed
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

@sayboras sayboras sayboras approved these changes

@zacharysarah zacharysarah Awaiting requested review from zacharysarah zacharysarah is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@learnitall @sayboras @meyskens @borkmann