-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.13 Backports 2023-06-26 #26477
Merged
Merged
v1.13 Backports 2023-06-26 #26477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit e4d277c ] In a config with native routing, the nodeport code in rev_nodeport_lb4() immediately redirects EgressGW reply traffic into the tunnel towards the client node. Test that this works in combination with TC. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit d511b55 ] this new type will be used in a subsequent commit to identify the context of each individual egress gateway test. Also rename tc_egressgw_snat2_reply to tc_egressgw_snat1_2_reply as tests 1 and 2 share the same context Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
added
kind/backports
This PR provides functionality previously merged into master.
backport/1.13
This PR represents a backport for Cilium 1.13.x of a PR that was merged to main.
labels
Jun 26, 2023
[ upstream commit 253b5e8 ] this is to decouple it from the reply parameter and make it more generic, in preparation for a new test Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 6376158 ] otherwise different tests will share and reuse the same NAT/CT entries, causing unexpected results due to the existing connections Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit e5a496a ] and use them to always clean up egress gateway policies after each test run Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit d458551 ] these helpers are used to install and remove an allow policy in the egressgw redirect tests to avoid packets being dropped Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 45fc79c ] since egressgw_snat_check has reached a high number of parameters, introduce a new egressgw_test_ctx struct that describes the context of a test/check, and use that as parameter of the egressgw_snat_{pktgen,snat} helpers Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 6ff3216 ] this should make it a bit more explicit what the test is doing Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit b12114c ] and rename egressgw_snat_pktgen to egressgw_pktgen, to reuse it in tc_egressgw_redirect.c and xdp_egressgw_reply.c Signed-off-by: Gilberto Bertin <jibi@cilium.io>
[ upstream commit 85388ee ] which is used to verify that a test returned a given action Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/v1.13-backport-2023-06-26
branch
from
June 26, 2023 08:59
0414eed
to
80cdd30
Compare
/test-backport-1.13 |
julianwiedmann
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Dropping the XDP test makes sense, tunnel from XDP worked very different in v1.13
.
/test-1.18-4.19 |
/test-1.20-4.19 |
ldelossa
approved these changes
Jun 29, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.13
This PR represents a backport for Cilium 1.13.x of a PR that was merged to main.
kind/backports
This PR provides functionality previously merged into master.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via:
or with