Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: remove ip shellout from setUpRoutingTable() #26486

Merged
merged 1 commit into from Jun 26, 2023

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jun 26, 2023

The default value of a netlink.Rule does not seem to be useful. netlink.NewRule must be used instead.

Fixes: #14383

Remove 'ip' shellout from setUpRoutingTable()

The default value of a netlink.Rule does not seem to be useful.
netlink.NewRule must be used instead.

Fixes: cilium#14383

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo requested a review from a team as a code owner June 26, 2023 16:20
@ti-mo ti-mo requested a review from jschwinger233 June 26, 2023 16:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 26, 2023
@ti-mo ti-mo added release-note/misc This PR makes changes that have no direct user impact. sig/agent Cilium agent related. labels Jun 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 26, 2023
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 26, 2023

/test

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting TIL, thanks!

@ti-mo ti-mo merged commit 764b796 into cilium:main Jun 26, 2023
65 of 66 checks passed
@ti-mo ti-mo deleted the tb/remove-ip-rule-shellout branch June 26, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/agent Cilium agent related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate workaround in privileged tests for netlink.RuleAdd() returning EINVAL
2 participants