Add container scanning workflow with Grype #26489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ferozsalam
commented
Jun 26, 2023
ferozsalam
commented
- Scans the same list of images as used in the Image CI build
- Runs daily + on demand
- Fails if any Critical issues are discovered
- Scans the same list of images as used in the Image CI build - Runs daily + on demand - Fails if any Critical issues are discovered Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
ferozsalam
force-pushed
the
pr/add-container-scanning
branch
from
70e5404
to
3471c44
Compare
|
Do we need to do anything special in order to test this workflow before we merge it? |
|
@joestringer I've tested the workflow using act and it works as intended. In any case, this will not block anyone from merging code, and is only set to run infrequently, so I think the chances of negative side effects are minimal. Let me know if there's anything further you think I should test though! |
ferozsalam
added
the
ready-to-merge
|
The failing CI checks seem unrelated to my change, so have marked this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.