Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "agent/helm: Deprecate --kpr=partial|strict|disabled and use --kpr=true|false instead" #26493

Merged
merged 5 commits into from Jun 26, 2023
Merged

Revert "agent/helm: Deprecate --kpr=partial|strict|disabled and use --kpr=true|false instead" #26493

merged 5 commits into from Jun 26, 2023

Conversation

joestringer
Copy link
Member

  • Revert "gh/workflows: Use --kpr=true instead of --kpr=strict"
  • Revert "api/daemon: Extend KPR status to show new states"
  • Revert "helm: Add --kube-proxy-replacement=boolean"
  • Revert "agent: Change flag defaults of ExternalIPs and HostPort"
  • Revert "agent: Add --kube-proxy-replacement=true|false"

Reverts: #26036

This PR breaks the main tree:

https://github.com/cilium/cilium/actions/runs/5383703690/jobs/9770782438

@joestringer
Revert "gh/workflows: Use --kpr=true instead of --kpr=strict"
8626845 
This reverts commit 1de430f.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Revert "api/daemon: Extend KPR status to show new states"
b1f409e 
This reverts commit 5cfafd2.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Revert "helm: Add --kube-proxy-replacement=boolean"
8332872 
This reverts commit c2c9121.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Revert "agent: Change flag defaults of ExternalIPs and HostPort"
f6e4b86 
This reverts commit b236a55.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Revert "agent: Add --kube-proxy-replacement=true|false"
9dc0541 
This reverts commit ad84df8.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested review from a team as code owners June 26, 2023 23:18
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 26, 2023
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jun 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 26, 2023
@joestringer joestringer merged commit 499b5d2 into main Jun 26, 2023
36 of 37 checks passed
@joestringer joestringer deleted the pr/joe/fix-main-branch-kpr branch June 26, 2023 23:18
@brb brb mentioned this pull request Jun 27, 2023
Merged
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril Awaiting requested review from nebril nebril is a code owner automatically assigned from cilium/ci-structure

@asauber asauber Awaiting requested review from asauber asauber is a code owner automatically assigned from cilium/cli

@jschwinger233 jschwinger233 Awaiting requested review from jschwinger233 jschwinger233 is a code owner automatically assigned from cilium/sig-datapath

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/api

@viktor-kurchenko viktor-kurchenko Awaiting requested review from viktor-kurchenko viktor-kurchenko is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joestringer