cni-plugin: Clean up code #26505
Merged
cni-plugin: Clean up code #26505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces more idiomatic error handling to `cmdAdd` and `cmdDel` in the CNI plugin code. In Golang, if one has a named return argument such as `func f() (err error)` and one refers to `err` in a `defer` statement, then it is not necessary to manually assign errors to `err`. The statement `return foo` will automatically assign `err = foo` and thus make the value `foo` visible in any defer statement. This commit contains no functional changes. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This commit removes a variable which can be inlined, as it is only used once. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This commit removes the C89 style "variable declaration block" in the CNI plugin and moves all variables declaration closer to their actual initalization point. This commit contains no functional changes. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
It is not used anywhere. This contains no functional changes. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/cni
squeed
approved these changes
Jun 27, 2023
|
/test |
|
ci-multicluster with Restarting. Edit: Created the following issue, since this seems to happen in other PRs too: |
|
/ci-multicluster |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the CNI code in preparation for changes coming in subsequent PRs.