Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Multi-Pool IPAM now partially supports iptables-based NAT #26522

Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented Jun 28, 2023

With #26397 merged, iptables-based masquerading can now be used together with Multi-Pool IPAM, as long as egressMasqueradeInterfaces is set too. I have locally verified that #26397 fixed the issues with Multi-Pool IPAM.

This commit adjusts the documentation to reflect that, and improves the wording a bit.

@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/ipam IP address management, including cloud IPAM area/ipam Impacts IP address management functionality. labels Jun 28, 2023
@gandro gandro requested a review from tklauser June 28, 2023 08:58
@gandro gandro requested review from a team as code owners June 28, 2023 08:58
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 28, 2023
@gandro gandro added the release-note/misc This PR makes changes that have no direct user impact. label Jun 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 28, 2023
With cilium#26397 merged, iptables-based masquerading can now be used together
with Multi-Pool IPAM, as long as `egressMasqueradeInterfaces` is set
too.

This commit adjusts the documentation to reflect that and improves the
wording of that section a bit.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro force-pushed the pr/gandro/docs-multi-pool-egress-nat-fixes branch from 06dd187 to df20c1d Compare June 28, 2023 11:32
@gandro gandro added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jun 29, 2023
@gandro
Copy link
Member Author

gandro commented Jul 3, 2023

This docs PR does not need a full CI run. Docs pipeline is green, marking ready to merge.

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 3, 2023
@borkmann borkmann merged commit 970f881 into cilium:main Jul 3, 2023
40 checks passed
@joamaki joamaki mentioned this pull request Jul 5, 2023
23 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 5, 2023
@jibi jibi added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/ipam Impacts IP address management functionality. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants