Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka: remove unused package #26523

Merged
merged 1 commit into from Jun 28, 2023
Merged

kafka: remove unused package #26523

merged 1 commit into from Jun 28, 2023

Conversation

tklauser
Copy link
Member

It's unused since proxylib was moved to the cilium/proxy repo in commit 51fc881 ("proxylib: Remove proxylib module").

@tklauser
kafka: remove unused package
e12aab3 
It's unused since proxylib was moved to the cilium/proxy repo in commit
51fc881 ("proxylib: Remove proxylib module").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added kind/cleanup This includes no functional changes. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels Jun 28, 2023
@tklauser tklauser requested a review from sayboras June 28, 2023 09:05
@tklauser tklauser requested review from a team as code owners June 28, 2023 09:05
@tklauser
Copy link
Member Author

/test

sayboras
sayboras approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ✔️

rolinh
rolinh approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

+0 −7,255

☝️ best kind of diff!

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 28, 2023
@tklauser
Copy link
Member Author

marked as ready to merge given the outstanding reviews for @cilium/docs-structure and @cilium/contributing are for trivial deletions due to the package being removed.

@borkmann borkmann merged commit 787c643 into main Jun 28, 2023
66 checks passed
@borkmann borkmann deleted the pr/tklauser/rm-pkg-kafka branch June 28, 2023 11:17
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@sayboras sayboras sayboras approved these changes

@bimmlerd bimmlerd Awaiting requested review from bimmlerd bimmlerd is a code owner automatically assigned from cilium/contributing

@learnitall learnitall Awaiting requested review from learnitall learnitall is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tklauser @rolinh @sayboras @borkmann