Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: display textual representation of auth type in authKey.String() #26525

Merged
merged 1 commit into from Jun 28, 2023
Merged

auth: display textual representation of auth type in authKey.String() #26525

merged 1 commit into from Jun 28, 2023

Conversation

mhofstetter
Copy link
Member

Currently, the numeric representation of the auth type is displayed when displaying textual representation of the authKey. This isn't ideal when logging the authkey as field within a log message.

To facilitate log message analysis, this commit changes this to use the textual representation of the auth type when displaying the auth key.

level=debug msg="Handle authentication request" key="<...>, authType=1" subsys=auth

->

level=debug msg="Handle authentication request" key="<...>, authType=spire" subsys=auth

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh feature/authentication labels Jun 28, 2023
@mhofstetter mhofstetter requested a review from a team as a code owner June 28, 2023 09:35
@mhofstetter
auth: display textual representation of auth type in authKey.String()
f975786 
Currently, the numeric representation of the auth type is displayed when
displaying textual representation of the authKey. This isn't ideal when
logging the authkey as field within a log message.

Therefore, this commit changes this to use the textual representation of
the auth type when displaying the auth key.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added the release-blocker/1.14 This issue will prevent the release of the next version of Cilium. label Jun 28, 2023
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/authkey-string-rep branch from c0cf2ea to f975786 Compare June 28, 2023 09:46
meyskens
meyskens approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, world of difference. LGTM!

@mhofstetter
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 28, 2023
@borkmann borkmann merged commit 76d6e75 into cilium:main Jun 28, 2023
64 of 65 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/authkey-string-rep branch June 28, 2023 12:16
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh feature/authentication kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhofstetter @meyskens @borkmann