bgpv1: set correct upper limits to BPG timers and GR restart time #26534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsimran-pabla
added
release-note/misc
harsimran-pabla
force-pushed
the
hpabla/set_max_restart_time
branch
from
f05c465
to
444f114
Compare
rastislavs
force-pushed
the
hpabla/set_max_restart_time
branch
from
1389df9
to
9949ae7
Compare
rastislavs
added
the
kind/enhancement
BGP holdtime is 16bits unsigned int and GR restart time is 12bits. Setting this limit in cilium BGP CRDs, so configuration can validated at the API layer. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
ConnectRetryTime is not negotiated with the peer and therefore there is no strict protocol limit for it. Internally, GoBGP uses int type to manage this timeout. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
hpabla/set_max_restart_time
branch
from
9949ae7
to
54bb614
Compare
|
/test |
|
should this be marked for 1.14 backport? |
rastislavs
added
the
backport/1.14
I think it makes sense, as this enhances validation of the CRD fields that will be first released in 1.14 - I just marked it. |
joamaki
added
needs-backport/1.14
squeed
approved these changes
Jul 4, 2023
YutaroHayakawa
approved these changes
Jul 4, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
joamaki
added
backport-pending/1.14
jibi
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGP holdtime is 16 bits unsigned int and GR restart time is 12 bits.
This limit is set in cilium BGP CRDs to validate configuration at the API layer.