hubble: Optimize namespace tracking #26547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibsm
added
area/daemon
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
glibsm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kaworu
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Thanks for the patch @glibsm!
pkg/hubble/relay/observer/server.go needs to be adapted accordingly.
Note that after the patch, adding a flow's src/dst namespaces is no longer "atomic" from the namespaceManager point of view but I don't think that's an issue.
|
We should back port this to 1.14 since this functionality is new in 1.14 and that memory increase could be viewed as a performance regression. |
chancez
added
the
needs-backport/1.14
Avoiding the use of varargs saves some allocations Before ``` Benchmark_TrackNamespaces-12 5122684 231.8 ns/op 192 B/op 6 allocs/op ``` After ``` Benchmark_TrackNamespaces-12 6114062 187.9 ns/op 168 B/op 4 allocs/op ``` Signed-off-by: Glib Smaga <code@gsmaga.com>
glibsm
force-pushed
the
pr/glibsm/optimize-namespace-tracking
branch
from
ec5c36c
to
f2ca387
Compare
chancez
approved these changes
Jul 10, 2023
kaworu
approved these changes
Jul 11, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.0
aanm
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding the use of varargs saves some allocations
Before
After