Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v1.14 stable branch #26548

Merged
merged 1 commit into from Jul 5, 2023
Merged

Prepare v1.14 stable branch #26548

merged 1 commit into from Jul 5, 2023

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Jun 28, 2023

Notes:

  • MLH configuration dropped jenkins flake correlator since main / v1.14
    doesn't use jenkins any more.
  • v1.13 stable branch dropped Go caching in the CI builds, so i also dropped the caching in this Pr. I based the change on the main branch workflows but following the diff from 1.12..1.13

Open questions:

  • There's quite a few workflows that use the default branch for checkout via
    github.event.repository.default_branch, but it's not clear to me how
    we should customize such workflows for the v1.14 stable branch.t sh

edit by @aanm: The workflows should keep using the github.event.repository.default_branch so that they can use the environment variables that we define in https://github.com/cilium/cilium/blob/d90803cec8e7a1508558b183600cde7dcbdd719f/.github/actions/set-env-variables/action.yml

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 28, 2023
@joestringer joestringer mentioned this pull request Jun 28, 2023
51 tasks
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jun 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 30, 2023
Notes:
- MLH configuration dropped jenkins flake correlator since main / v1.14
  doesn't use jenkins any more.
- v1.13 stable branch dropped Go caching in the CI builds, but this time
  around I kept it. I suspect that this caching was only dropped from
  v1.13 CI builds because at the time I had copied the old v1.12 version
  of the workflow into the v1.13 tree in order to do this
  initialization. This time I based the change on main.

Open questions:
- There's quite a few workflows that use the default branch for checkout via
  `github.event.repository.default_branch`, but it's not clear to me how
  we should customize such workflows for the v1.14 stable branch.t sh

Signed-off-by: Joe Stringer <joe@cilium.io>
@aanm aanm marked this pull request as ready for review July 4, 2023 15:25
@aanm aanm requested review from a team as code owners July 4, 2023 15:25
@aanm aanm requested review from squeed, dylandreimerink, aanm and nebril and removed request for a team July 4, 2023 15:25
@aanm aanm merged commit 4fae666 into v1.14 Jul 5, 2023
53 checks passed
@aanm aanm deleted the pr/joe/v1.14-branch branch July 5, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants