Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Mention --kube-proxy-replacement=boolean changes #26577

Merged
merged 2 commits into from Jul 5, 2023
Merged

docs: Mention --kube-proxy-replacement=boolean changes #26577

merged 2 commits into from Jul 5, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jun 30, 2023 •
edited

Docs follow up of #26036.

Fix #25988

@brb brb added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. area/loadbalancing Impacts load-balancing and Kubernetes service implementations needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jun 30, 2023
@brb brb marked this pull request as ready for review June 30, 2023 13:00
@brb brb requested review from a team as code owners June 30, 2023 13:00
@brb brb requested review from ysksuzuki and learnitall June 30, 2023 13:00
@brb brb force-pushed the pr/brb/docs-kpr-boolean branch from d0d2831 to f4613d2 Compare June 30, 2023 13:18
@brb brb requested a review from borkmann June 30, 2023 13:19
qmonnet
qmonnet approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, feel free to ignore.

Nice!

Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
@brb brb force-pushed the pr/brb/docs-kpr-boolean branch from f4613d2 to f5bb019 Compare July 4, 2023 07:23
@qmonnet
Copy link
Member

qmonnet commented Jul 4, 2023

Doc-only changes, and the relevant workflow passed. All good to go

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 4, 2023
@borkmann borkmann added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 5, 2023
brb added 2 commits July 5, 2023 11:40
@brb
docs: Mention changes of --kpr=boolean in upgrade guide
7bd7e63 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
docs: Adjust KPR GSG to --kpr=boolean changes
1df74d9 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/docs-kpr-boolean branch from f5bb019 to 1df74d9 Compare July 5, 2023 09:41
@brb brb removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 5, 2023
@borkmann borkmann merged commit 1a4e7d4 into main Jul 5, 2023
40 checks passed
@borkmann borkmann deleted the pr/brb/docs-kpr-boolean branch July 5, 2023 12:48
@qmonnet qmonnet mentioned this pull request Jul 6, 2023
Merged
@jibi jibi mentioned this pull request Jul 10, 2023
Merged
19 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 10, 2023
@julianwiedmann julianwiedmann added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 11, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
@qmonnet qmonnet mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@qmonnet qmonnet qmonnet approved these changes

@learnitall learnitall Awaiting requested review from learnitall learnitall is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/loadbalancing Impacts load-balancing and Kubernetes service implementations backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

agent: Deprecate --kube-proxy-replacement=partial
6 participants
@brb @qmonnet @borkmann @ysksuzuki @jibi @julianwiedmann