bgpv1: Unconditionally select node when empty nodeSelector is given #26590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRD spec of CiliumBGPPeeringPolicy states ``` NodeSelector selects a group of nodes where this BGP Peering Policy applies. If empty / nil this policy applies to all nodes. ``` However, our current implementation treats empty / nil selector as an error. This commit fixes it. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added
kind/bug
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
YutaroHayakawa
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
|
/ci-multicluster |
|
/ci-aks |
|
In our current code, only a single CiliumBGPPeeringPolicy may apply to a node. So in this change, what happens if multiple 'CiliumBGPPeeringPolicies' do not specify a node selector? We will pick the latest created 'CiliumBGPPeeringPolicy' and ignore all others, correct? |
ldelossa
requested changes
Jul 5, 2023
No, essentially the empty/nil selector is a selector that selects everything. So, when there are multiple policies select the same node, BGP sessions will be reset. This is the same behavior as before. |
ldelossa
approved these changes
Jul 6, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
jibi
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.5
jibi
added
the
backport/author
YutaroHayakawa
added
backport/author
1 task
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.12
julianwiedmann
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.5
julianwiedmann
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.12
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRD spec of CiliumBGPPeeringPolicy states
However, our current implementation treats empty / nil selector as an error. This commit fixes it.
This issue was reported by an OSS community user on Slack.