Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update external workloads instructions #26607

Merged
merged 1 commit into from Jul 5, 2023
Merged

docs: Update external workloads instructions #26607

merged 1 commit into from Jul 5, 2023

Conversation

michi-covalent
Copy link
Contributor

No description provided.

@michi-covalent michi-covalent requested a review from a team as a code owner July 3, 2023 22:17
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 3, 2023
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Jul 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 3, 2023
@michi-covalent michi-covalent added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. labels Jul 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 3, 2023
@michi-covalent michi-covalent mentioned this pull request Jul 3, 2023
Closed
18 tasks
qmonnet
qmonnet approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once Marco's feedback is sorted.

Same comment as on #26608 (comment), do you need a needs-backport/1.14 label here?

@michi-covalent michi-covalent added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 5, 2023
@michi-covalent
docs: Update external workloads instructions
49eb1b0 
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@qmonnet
Copy link
Member

qmonnet commented Jul 5, 2023 •
edited

Doc-change only - codeowners reviews are in, and the relevant workflows passed successfully. We're good to merge this.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 5, 2023
@borkmann borkmann merged commit b9f467a into main Jul 5, 2023
40 checks passed
@borkmann borkmann deleted the pr/michi/external-lets-go branch July 5, 2023 09:24
@jibi jibi mentioned this pull request Jul 10, 2023
Merged
19 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 10, 2023
@julianwiedmann julianwiedmann added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 11, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@giorio94 giorio94 giorio94 approved these changes

@learnitall learnitall Awaiting requested review from learnitall learnitall is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@michi-covalent @qmonnet @giorio94 @jibi @borkmann @julianwiedmann