Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update cluster mesh instructions #26608

Merged
merged 1 commit into from Jul 5, 2023
Merged

docs: Update cluster mesh instructions #26608

merged 1 commit into from Jul 5, 2023

Conversation

michi-covalent
Copy link
Contributor

  • Only document using the Helm mode. Time to deprecate the classic mode.
  • Remove "clustermesh enable" and "clustermesh connect" output samples. These outputs might change in the future, and I think output samples from the subsequent "clustermesh status" commands give users enough context to confirm that "clustermesh enable" and "clustermesh connect" commands succeeded.

@michi-covalent michi-covalent added release-note/misc This PR makes changes that have no direct user impact. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. labels Jul 3, 2023
@michi-covalent michi-covalent requested review from a team as code owners July 3, 2023 23:23
qmonnet
qmonnet approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, thanks!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/cli Impacts the command line interface of any command in the repository. labels Jul 4, 2023
@qmonnet
Copy link
Member

qmonnet commented Jul 4, 2023 •
edited

I see this is a release blocker for 1.14:

  • Just double-checking: has the deprecation for the legacy mode happened yet and are we ready to push this to 1.14?
  • If so, given that we've branched already, you probably want a needs-backport/1.14 label?

@qmonnet
Copy link
Member

qmonnet commented Jul 4, 2023

Also, I wonder: Would it help to have a note on the change of default mode for the Cilium CLI in the upgrade notes?

@qmonnet qmonnet mentioned this pull request Jul 4, 2023
Merged
@michi-covalent michi-covalent added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 5, 2023
@michi-covalent
docs: Update cluster mesh instructions
e460541 
- Only document using the Helm mode. Time to deprecate the classic mode.
- Remove "clustermesh enable" and "clustermesh connect" output samples.
  These outputs might change in the future, and I think output samples
  from the subsequent "clustermesh status" commands give users enough
  context to confirm that "clustermesh enable" and "clustermesh connect"
  commands succeeded.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

Just double-checking: has the deprecation for the legacy mode happened yet and are we ready to push this to 1.14?
If so, given that we've branched already, you probably want a needs-backport/1.14 label?

yeah we are ready. added needs-backport/1.14 label. thanks for the heads up 🚀

Also, I wonder: Would it help to have a note on the change of default mode for the Cilium CLI in the upgrade notes?

yeah we should do that, @giorio94 also pointed this out in #26606 (review). i'll add upgrade notes in #26606 📝

@qmonnet
Copy link
Member

qmonnet commented Jul 5, 2023

Sounds good, thanks!

Doc-change only - codeowners reviews are in, and the relevant workflows passed successfully. We're good to merge this.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 5, 2023
@borkmann borkmann merged commit c426dc8 into main Jul 5, 2023
40 checks passed
@borkmann borkmann deleted the pr/michi/cluster-mesh-lets-go branch July 5, 2023 09:24
@michi-covalent michi-covalent mentioned this pull request Jul 5, 2023
Merged
@jibi jibi mentioned this pull request Jul 10, 2023
Merged
19 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 10, 2023
@julianwiedmann julianwiedmann added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 11, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@qmonnet qmonnet qmonnet approved these changes

@giorio94 giorio94 giorio94 approved these changes

@learnitall learnitall Awaiting requested review from learnitall learnitall is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@michi-covalent @qmonnet @YutaroHayakawa @giorio94 @jibi @borkmann @julianwiedmann