bpf: exclude EgressGW logic in bpf_overlay #26611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te() We only want to apply the MASQUERADE logic when snat_v*_prepare_state() is called from bpf_host (ie to-netdev). Make this a bit clearer in the code. No functional change, except that we avoid the local_ep / remote_ep handling when MASQUERADE is disabled. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
EgressGW uses the masquerading logic in to-netdev. Avoid including these code sections in bpf_overlay. Also don't consider EgressGW in bpf_overlay when deciding whether handle_nat_fwd_ipv4() can be inlined. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
The nodeport ingress path contains a special path that immediately redirects replies for EgressGW connections into the tunnel (bypassing the stack). This path is only required for bpf_xdp and bpf_host, exclude it from bpf_overlay. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-bpf-egressgw-overlay
branch
from
f1b0250
to
c262dd7
Compare
|
/test |
julianwiedmann
changed the title
dylandreimerink
approved these changes
Jul 5, 2023
jibi
approved these changes
Jul 6, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly exclude the EgressGW-specific paths when the
nodeport.handnat.hcode is pulled into bpf_overlay. They are not needed, all relevant EgressGW functionality lives in bpf_host (and bpf_xdp).Motivation is mostly about better self-documentation ("where does this code run"), there's no pressing BPF complexity concerns for bpf_overlay.