test: print logical instruction count per program #26641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
Looks good: imho we could even add this to the log output when no error occurs (for before/after comparison). But happy to do that as follow-on. |
ti-mo
force-pushed
the
tb/verifier-test-insn-count
branch
from
03c3667
to
ce8b1f9
Compare
No, good call, was an extra line of changes. :) Might as well change it while we're at it. |
ti-mo
changed the title
ti-mo
force-pushed
the
tb/verifier-test-insn-count
branch
from
ce8b1f9
to
534b62f
Compare
nice, thank you! lgtm. |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
As it says on the tin, echo instruction count for all programs, both if the
Collection fails to load, as well as at the end of the last line of the
verifier log on a successful load.
Example output of successful load:
```
=== RUN TestVerifier/bpf_host_1
verifier_test.go:216: tail_srv6_reply: processed 277 insns (limit 1000000) ... mark_read 8 (201 unverified insns)
...
```
Example output of unsuccessful load:
```
=== RUN TestVerifier/bpf_lxc_1
verifier_test.go:201: Full verifier log at bpf_lxc_1_verifier.log
verifier_test.go:203: BPF unverified instruction count per program:
verifier_test.go:205: tail_handle_ipv4: 1048 insns
```
Also output the original `err` containing the name of the prog that caused
the verifier error, which was accidentally removed by 1833964
("test/verifier: don't dump full log into test output"). It's now
documented why it's included.
Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/verifier-test-insn-count
branch
from
534b62f
to
6fb37c1
Compare
|
/test |
christarazi
approved these changes
Jul 18, 2023
christarazi
added
the
area/CI-improvement
lmb
approved these changes
Jul 19, 2023
ti-mo
added
the
ready-to-merge
|
Gateway and ingress conformance tests didn't skip for some reason. Flagged this internally. Marking ready. |
|
Think it would be good to have this in |
julianwiedmann
added
the
needs-backport/1.14
tklauser
added
backport-pending/1.14
joestringer
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin, echo instruction count for all programs, both if the Collection fails to load, as well as at the end of the last line of the verifier log on a successful load.
Example output of successful load:
Example output of unsuccessful load: