statedb: extract REST API handler to pkg #26645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimmlerd
added
kind/cleanup
bimmlerd
force-pushed
the
pr/bimmlerd/statedb-api-handler-extraction
branch
2 times, most recently
from
2328d3c
to
91c49d1
Compare
joamaki
reviewed
Jul 5, 2023
joamaki
reviewed
Jul 5, 2023
bimmlerd
force-pushed
the
pr/bimmlerd/statedb-api-handler-extraction
branch
2 times, most recently
from
e72823b
to
614f048
Compare
|
/test |
With the newly modularized API server, we can pull out individual handlers into their packages; in this case the statedb Dump handler. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
force-pushed
the
pr/bimmlerd/statedb-api-handler-extraction
branch
from
614f048
to
e8bf13d
Compare
|
/test |
|
CI triage:
|
|
/ci-e2e |
joamaki
approved these changes
Jul 17, 2023
| @@ -22,6 +22,7 @@ var Cell = cell.Module( | |||
| "In-memory database", | |||
|
|
|||
| cell.Provide(New), | |||
| cell.Provide(newDumpHandler), // REST API Handler | |||
There was a problem hiding this comment.
nit(in case you rebase): you can collapse the provide's into one which I find
easier to read:
cell.Provide(
New,
newDumpHandler, // The /statedb/dump REST API handler
)
maintainer-s-little-helper
bot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the newly modularized API server, we can pull out individual handlers into their packages; in this case the statedb Dump handler.