Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-pool: Document unsupported kvstore mode #26662

Merged
merged 1 commit into from Jul 7, 2023
Merged

multi-pool: Document unsupported kvstore mode #26662

merged 1 commit into from Jul 7, 2023

Conversation

gandro
Copy link
Member

@gandro gandro commented Jul 6, 2023

This commit adds a check and documentation that kvstore-based identity allocation mode is currently not supported. This is due to #26621. We intend to fix that in Cilium v1.15.

@gandro
multi-pool: Document unsupported kvstore mode
2e64427 
This commit adds a check and documentation that kvstore-based identity
allocation mode is currently not supported. This is due to cilium#26621. We
intend to fix that in Cilium v1.15.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM sig/kvstore Impacts the KVStore package interactions. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. area/ipam Impacts IP address management functionality. labels Jul 6, 2023
@gandro gandro requested review from a team as code owners July 6, 2023 08:29
@gandro gandro mentioned this pull request Jul 6, 2023
Closed
2 tasks
@gandro
Copy link
Member Author

gandro commented Jul 6, 2023

Integrations tests hit #26617 - restarting

@gandro
Copy link
Member Author

gandro commented Jul 6, 2023

/test

@gandro gandro mentioned this pull request Jul 6, 2023
Closed
@gandro
Copy link
Member Author

gandro commented Jul 6, 2023

@gandro
Copy link
Member Author

gandro commented Jul 6, 2023 •
edited

/ci-aks

Edit: Run https://github.com/cilium/cilium/actions/runs/5474746995 hit #22162 - restarting

@gandro gandro mentioned this pull request Jul 5, 2023
Closed
29 tasks
lambdanis
lambdanis approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs ok

@pippolo84 pippolo84 mentioned this pull request Jul 6, 2023
Merged
@gandro gandro mentioned this pull request Jul 6, 2023
Closed
@gandro
Copy link
Member Author

gandro commented Jul 6, 2023

/ci-aks

@tklauser tklauser merged commit 751fc71 into cilium:main Jul 7, 2023
66 checks passed
@tklauser tklauser added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 7, 2023
@jibi jibi mentioned this pull request Jul 10, 2023
Merged
19 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 10, 2023
@julianwiedmann julianwiedmann added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 11, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@lambdanis lambdanis lambdanis approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-ipam

Assignees
No one assigned
Labels
area/ipam Impacts IP address management functionality. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM sig/kvstore Impacts the KVStore package interactions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gandro @tklauser @lambdanis @jibi @julianwiedmann