helm,docs: Add client rate limit helm values #26711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
kind/enhancement
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
dylandreimerink
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
dylandreimerink
force-pushed
the
feature/k8s-rate-limit-helm-values
branch
5 times, most recently
from
fda3312
to
4ee84f5
Compare
dylandreimerink
force-pushed
the
feature/k8s-rate-limit-helm-values
branch
2 times, most recently
from
17c4230
to
6c97764
Compare
joamaki
approved these changes
Jul 10, 2023
dylandreimerink
force-pushed
the
feature/k8s-rate-limit-helm-values
branch
2 times, most recently
from
9664a61
to
89ecec8
Compare
This commit adds the helm values for the client rate limit feature. This makes it easier for users to tune the client rate limit which is necessary for L2 announcements to work properly. Added warnings about client rate limits and sizing instructions to the L2 announcements documentation. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/k8s-rate-limit-helm-values
branch
from
89ecec8
to
8243c5f
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.0
aanm
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.0
sayboras
reviewed
Jul 21, 2023
Comment on lines
+3194
to
+3205
|
|
||
| # -- Configure the client side rate limit for the agent and operator | ||
| # | ||
| # If the amount of requests to the Kubernetes API server exceeds the configured | ||
| # rate limit, the agent and operator will start to throttle requests by delaying | ||
| # them until there is budget or the request times out. | ||
| k8sClientRateLimit: | ||
| # -- The sustained request rate in requests per second. | ||
| qps: 5 | ||
| # -- The burst request rate in requests per second. | ||
| # The rate limiter will allow short bursts with a higher rate. | ||
| burst: 10 |
There was a problem hiding this comment.
is this block the same as above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the helm values for the client rate limit feature. This makes it easier for users to tune the client rate limit which is necessary for L2 announcements to work properly.
Added warnings about client rate limits and sizing instructions to the L2 announcements documentation.
This doesn't fully address #26586 since we are putting an additional burden on the user, but should provide a half decent workaround for the v1.14 release which gives us time to come up with a permanent more user friendly fix.