Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix minor TOC issues #26714

Merged
merged 1 commit into from Jul 10, 2023
Merged

docs: fix minor TOC issues #26714

merged 1 commit into from Jul 10, 2023

Conversation

networkop
Copy link
Contributor

  • The first issue is that lb-ipam is present in both BGP and Networking TOC. This change removes it from the top-level Networking TOC
  • The second issue is the Kubernetes compatibility TOC displayed a subsection (CRD validation) at the same level as its parent.

@networkop
docs: fix minor TOC issues
ddc8ab1 
* The first issue is that lb-ipam is present in both BGP and Networking
TOC. This change removes it from the top-level Networking TOC
* The second issue is the Kubernetes compatibility TOC displayed a
subsection (CRD validation) at the same level as its parent.

Signed-off-by: Michael Kashin <michael.kashin@isovalent.com>
@networkop networkop requested review from a team as code owners July 7, 2023 15:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 7, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 7, 2023
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Jul 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 10, 2023
@joamaki joamaki added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 10, 2023
@joamaki
Copy link
Contributor

joamaki commented Jul 10, 2023

Marking ready-to-merge as doc builds pass.

@julianwiedmann julianwiedmann added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jul 10, 2023
@julianwiedmann julianwiedmann merged commit 8e37f1f into cilium:main Jul 10, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@lambdanis lambdanis lambdanis approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@networkop @joamaki @lambdanis @julianwiedmann