egressgw: improve reconciliation for IP rules #26736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
release-note/misc
|
/test |
route.ReplaceRule() internally fetches the whole set of IP rules in the system. So calling addEgressIpRule() for every EgressGW-eligible endpoint causes quite a bit of churn. Instead fetch the rules just once per EgressGW policy (filtered for the policy's routing table). Then check for each of the policy's endpoints whether its IP rule already exists, and insert any rule that is missing. Note that there is further potential for improvement here - ideally we would fetch the whole rule set just once, dynamically filter it down to each policy's routing table, and only match the policy's endpoints against those specific rules. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
The current message looks copy&pasted from the previous error case. Adjust the text to describe what operation actually failed. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-egressgw-iprules
branch
from
d58b6e2
to
9490441
Compare
|
/test |
julianwiedmann
changed the title
gentoo-root
approved these changes
Jul 11, 2023
julianwiedmann
added
the
kind/enhancement
julianwiedmann
added
the
needs-backport/1.14
6 tasks
nbusseneau
added
backport-pending/1.14
joestringer
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #26721. Also improve the reconciliation for IP rules when EgressGW is used with
--install-egress-gateway-routes.