Egress Gateway: make CiliumEndpoint reconciliation asynchronous from k8s watcher #26741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
added
release-note/misc
jibi
force-pushed
the
pr/jibi/egressgw-async-eps
branch
from
03f69b3
to
1f3beaa
Compare
jibi
force-pushed
the
pr/jibi/egressgw-async-eps
branch
3 times, most recently
from
e82b589
to
1c4eeca
Compare
|
/test |
julianwiedmann
approved these changes
Jul 11, 2023
qmonnet
approved these changes
Jul 11, 2023
jibi
force-pushed
the
pr/jibi/egressgw-async-eps
branch
2 times, most recently
from
1b55722
to
cd2e032
Compare
aanm
approved these changes
Jul 12, 2023
|
Doc workflow failure is my fault, should be fixed with #26780. |
instead of running the reconciliation logic for each event received by the egress gateway manager, switch to a trigger based approach where each event simply triggers a reconciliation, and the actual reconciliation is be performed at most once every --egress-gateway-reconciliation-trigger-interval time interval. This should help reducing the CPU load in case the manager is dealing with lots of events (for example high churn of endpoints) Signed-off-by: Gilberto Bertin <jibi@cilium.io>
by:
* making locking more granular by introducing a new
pendingEndpointEventsLock lock that protects accesses to the
pendingEndpointEvents field
* using the endpoint workqueue to handle also CiliumEndpoint deletion
events
we can completely decouple the On{Update,Delete}Endpoint methods from
the reconciliation logic, as the caller will not have to block anymore
on the main manager lock (which is held during the entire reconciliation
process)
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-async-eps
branch
from
cd2e032
to
332cb45
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
aanm
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits
Fixes: #23976